Add the ability to correct audio offset for individual songs#1535
Add the ability to correct audio offset for individual songs#1535asimard1 wants to merge 19 commits into
Conversation
fc92f76 to
0021feb
Compare
0021feb to
4df7780
Compare
…ate if it's preferable)
…tion New commit was made into dev branch
…tion New dev commit
…tion Get new commit
…1/YARG into feature/song-calibration
|
What I'll do next is:
|
|
I was going to reply to your question from the other PR about where to save the JSON file, but it seems you have it well in hand. Normally things go in a subdirectory, but there's not really any place it obviously fits, so where you have it now is fine. As for how to add a toggle setting, the general idea is to define the settings in I hate adding other stuff that you'll have to figure out, but it would probably be best to make the button require a long press to activate so people won't be as prone to hitting it accidentally. It's not the most helpful pointer since it is large and spread out over several files, but |
|
This still requires just a bit of testing, but if anyone could test this with more than one player it would be great. Appart from that everything should be done. (Tested, works fine except when playing online because of the delay.) edit: Thank you wyrdough for your help with finding the necessary files, everything was easy to adapt :) edit: Tested with more than one player and it works perfectly |
Added TODO comments for future online functionality.

Adds a button on the score screen that applies the average hit-timing offset (ScoreScreenStats.AverageOffset, computed from non-bot players) to the song's delay value in song.ini. The button toggles between "Add Song Offset" and "Remove Song Offset" so the change can be undone with a second press. Also adds AverageOffset to ScoreScreenStats, populated as the mean GetAverageOffset() across non-bot players.
Bound to the Select action.